[riot-notifications] [RIOT-OS/RIOT] sys/net/dhcpv6: Refactor IA_NA implementation (#16724)

Jan Romann notifications at github.com
Thu Aug 12 01:29:31 CEST 2021


@JKRhb commented on this pull request.



> @@ -15,6 +15,11 @@
 
 
 IA_NA_ADDRESS_POOL_PREFIX = "2001:db8:1::"
+IA_PD_PREFIX = "2001:db8:8000::"
+
+
+def assert_unique_elements(*args):
+    assert len(args) == len(set(args))

I was actually thinking that there might be a third test case (e. g. IA_TA) added later which could be more easily tested this way than making individual assertions. But you right that this makes things unnecessarily complicated. I changed it in one of the fixup commits.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16724#discussion_r687260847
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210811/8e3db384/attachment.htm>


More information about the notifications mailing list