[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6_simple_subnets: auto-configuration for nested subnets on a simple tree topology (#16536)

Martine Lenders notifications at github.com
Thu Aug 12 19:21:07 CEST 2021


@miri64 commented on this pull request.

With the current module name I think it will cause a lot of confusion where to find it. Also it's quite long. I suggest to come up with a funny name or TLA, to avoid confusion. Regardless, file naming should follow the conventions.

> @@ -0,0 +1,3 @@
+MODULE = gnrc_ipv6_simple_subnets

Module location should match the module name, so

` sys/net/gnrc/routing/simple_subnets/` ⇒ ` sys/net/gnrc/routing/ipv6_simple_subnets/`?

> @@ -0,0 +1,156 @@
+/*

And

`sys/net/gnrc/routing/simple_subnets/simple_subnets.c` ⇒ `sys/net/gnrc/routing/ipv6_simple_subnets/gnrc_ipv6_simple_subnets.c`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16536#pullrequestreview-728883158
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210812/9eaf88f0/attachment.htm>


More information about the notifications mailing list