[riot-notifications] [RIOT-OS/RIOT] gnrc: select gnrc_netif if netdev_default is selected (#16744)

José Alamos notifications at github.com
Mon Aug 16 16:57:10 CEST 2021

at least `git grep GNRC_NETDEV_DEFAULT ` returns blank and as it is now with this PR, `gnrc_netdev_default` and `netdev_default` are almost interchangeable.

> It looks like nrfmin and nimble_netif are only selected with gnrc_netdev_default, there might be a hard dependency there.

It seems that those lines just select `nimble_netif` if neither `nrfmin` nor `nrf802154` are present. It seems they could be replaced with:
diff --git a/boards/common/nrf52/Makefile.nimble.dep b/boards/common/nrf52/Makefile.nimble.dep
index a682d92a03..61bee67136 100644
--- a/boards/common/nrf52/Makefile.nimble.dep
+++ b/boards/common/nrf52/Makefile.nimble.dep
@@ -1,4 +1,4 @@
-ifneq (,$(filter gnrc_netdev_default,$(USEMODULE)))
+ifneq (,$(filter gnrc_netif,$(USEMODULE)))
   ifeq (,$(filter nrfmin nrf802154,$(USEMODULE)))
     USEMODULE += nimble_netif

We could then simply deprecate `gnrc_netdev_default` and just use `netdev_default` in a network stack independent manner. As of this PR, we could simply keep `gnrc_netdev_default` as it is but just add the deprecation note.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210816/0632d6b4/attachment.htm>

More information about the notifications mailing list