[riot-notifications] [RIOT-OS/RIOT] pkg/nimble/autoadv: make AD flag optionnal (#16703)

benpicco notifications at github.com
Wed Aug 18 17:48:17 CEST 2021


@benpicco commented on this pull request.



> @@ -160,8 +160,14 @@ void nimble_autoadv_reset(void)
     int rc = 0;
     (void) rc;
 
-    rc = bluetil_ad_init_with_flags(&_ad, buf, sizeof(buf), BLUETIL_AD_FLAGS_DEFAULT);
-    assert(rc == BLUETIL_AD_OK);
+    if (IS_ACTIVE(NIMBLE_AUTOADV_FLAG_FIELD)) {

Maybe even
```suggestion
    if (IS_ACTIVE(NIMBLE_AUTOADV_FLAG_FIELD) && BLUETIL_AD_FLAGS_DEFAULT) {
```
?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16703#pullrequestreview-733067686
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210818/a5ce6ea2/attachment.htm>


More information about the notifications mailing list