[riot-notifications] [RIOT-OS/RIOT] SAM0 cpu: persist RTC GP registers across reset (see #16756) (#16757)

benpicco notifications at github.com
Thu Aug 19 12:52:24 CEST 2021


@benpicco commented on this pull request.



> +    int i;
+    for (i = 0; i < RTC_GPR_NUM; i++) persist[i] = RTC->MODE0.GP[i].reg;

```suggestion
    for (unsigned i = 0; i < RTC_GPR_NUM; i++) {
        persist[i] = RTC->MODE0.GP[i].reg;
    }
```

No need to squish that all on one line :wink: 

> +#if CONFIG_SAM0_PERIPH_RTT_RTC_PERSIST_GPR
+#ifdef RTC_GPR_NUM

```suggestion
#if IS_ACTIVE(CONFIG_SAM0_PERIPH_RTT_RTC_PERSIST_GPR) && defined(RTC_GPR_NUM)
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16757#pullrequestreview-733842334
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210819/95708a8b/attachment.htm>


More information about the notifications mailing list