[riot-notifications] [RIOT-OS/RIOT] FIDO2 support in RIOT (#16489)

Leandro Lanzieri notifications at github.com
Thu Aug 19 14:38:46 CEST 2021


@leandrolanzieri commented on this pull request.



> +menuconfig MODULE_FIDO2_CTAP
+    bool "FIDO2 CTAP"
+    depends on TEST_KCONFIG
+    help
+        Configure a FIDO2 CTAP authenticator via KConfig.
+
+if MODULE_FIDO2_CTAP

To show the options when not using Kconfig dependency resolution, you should instead:
```suggestion
menuconfig KCONFIG_USEMODULE_FIDO2_CTAP
    bool "FIDO2 CTAP"
    depends on USEMODULE_FIDO_CTAP
    help
        Configure a FIDO2 CTAP authenticator via KConfig.

if KCONFIG_USEMODULE_FIDO2_CTAP
```



> +
+config FIDO2_CTAP_STACK_SIZE
+    int "CTAP thread stack size"
+    default 15000
+
+config FIDO2_CTAP_DEVICE_AAGUID
+    string "AAGUID of the CTAP authenticator"
+    default "9c295865fa2c36b705a42320af9c8f16"
+    help
+        The AAGUID is identifying the type of the authenticator (e.g manufacturer
+        and model). The AAGUID needs to be 128 bits long. The default value here
+        is a fallback value that was randomly generated.
+
+config FIDO2_CTAP_DISABLE_UP
+    bool "Disable user presence tests"
+    default n

No need to default `n`

> +    default "9c295865fa2c36b705a42320af9c8f16"
+    help
+        The AAGUID is identifying the type of the authenticator (e.g manufacturer
+        and model). The AAGUID needs to be 128 bits long. The default value here
+        is a fallback value that was randomly generated.
+
+config FIDO2_CTAP_DISABLE_UP
+    bool "Disable user presence tests"
+    default n
+    help
+        When set, the authenticator will not ask for permission before creating
+        a new credential pair or authenticating.
+
+config FIDO2_CTAP_DISABLE_LED
+    bool "Disable LED animations"
+    default n

Same

> @@ -26,6 +26,7 @@ rsource "eepreg/Kconfig"
 rsource "event/Kconfig"
 rsource "fmt/Kconfig"
 rsource "frac/Kconfig"
+rsource "fido2/Kconfig"

Please keep alphabetical order here

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16489#pullrequestreview-733930412
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210819/5ab42a17/attachment.htm>


More information about the notifications mailing list