[riot-notifications] [RIOT-OS/RIOT] FIDO2 support in RIOT (#16489)

benpicco notifications at github.com
Mon Aug 23 23:33:54 CEST 2021


@benpicco commented on this pull request.



> +int fido2_ctap_utils_init_gpio_pin(void)
+{
+    if (gpio_init_int(BTN0_PIN, BTN0_MODE, GPIO_FALLING, _gpio_cb, NULL) < 0) {

Why hardcode `BTN0_PIN` when you could just as well have

```suggestion
int fido2_ctap_utils_init_gpio_pin(gpio_t pin, gpio_mode_t mode, gpio_flank_t flank)
{
    if (gpio_init_int(pin, mode, flank, _gpio_cb, NULL) < 0) {
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16489#pullrequestreview-736587318
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210823/6c9a8574/attachment.htm>


More information about the notifications mailing list