[riot-notifications] [RIOT-OS/RIOT] gnrc/nib: consolidate prefix removal code in _nib_offl_remove_prefix() (#16729)

Martine Lenders notifications at github.com
Tue Aug 24 16:04:01 CEST 2021


@miri64 commented on this pull request.



> +            if (ipv6_addr_match_prefix(&netif->ipv6.addrs[i],
+                                       &pfx->pfx) >= pfx->pfx_len) {
+                gnrc_netif_ipv6_addr_remove_internal(netif,
+                                                     &netif->ipv6.addrs[i]);
+            }

> This code was just moved from `_handle_rtr_sol()` to it's own function.

And yepp, I believe that one is also wrong ;-). It does not even stop the loop, after the address was removed...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16729#discussion_r694882872
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210824/10bb7804/attachment.htm>


More information about the notifications mailing list