[riot-notifications] [RIOT-OS/RIOT] drivers/ili9341: add rotation mode to ili9341_params_t (#16773)

benpicco notifications at github.com
Wed Aug 25 13:31:31 CEST 2021


@benpicco commented on this pull request.



> +typedef enum {
+    ILI9341_ROTATION_VERT,      /**< Vertical mode */
+    ILI9341_ROTATION_VERT_FLIP, /**< Vertical flipped mode */
+    ILI9341_ROTATION_HORZ,      /**< Horizontal mode */
+    ILI9341_ROTATION_HORZ_FLIP, /**< Horizontal flipped mode */
+} ili9341_rotation_t;

Why not

```suggestion
#define ILI9341_ROTATION_VERT       ILI9341_MADCTL_VERT
#define ILI9341_ROTATION_VERT_FLIP  ILI9341_MADCTL_VERT_FLIP
#define ILI9341_ROTATION_HORZ       ILI9341_MADCTL_HORZ
#define ILI9341_ROTATION_HORZ_FLIP  ILI9341_MADCTL_HORZ_FLIP
```

and get rid of `_ili9341_calc_rotation()`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16773#pullrequestreview-738233298
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210825/7cc7b709/attachment-0001.htm>


More information about the notifications mailing list