[riot-notifications] [RIOT-OS/RIOT] test_utils: add UDP benchmark (#16710)

Karl Fessel notifications at github.com
Wed Aug 25 14:12:20 CEST 2021


@kfessel commented on this pull request.



> @@ -209,6 +213,9 @@ const shell_command_t _shell_command_list[] = {
 #ifdef MODULE_USB_BOARD_RESET
     {"bootloader", "Reboot to bootloader", _bootloader_handler},
 #endif
+#ifdef MODULE_BENCHMARK_UDP
+    {"benchmark", "UDP benchmark", _benchmark_udp_handler},

I am not sure if there will be any other benchmark in RIOT (e.g.: the for the developing tcp), maybe this should not capture this generic term but use its modulname (unique within RIOT) for the shell interface.
```suggestion
    {"benchmark_udp", "UDP benchmark", _benchmark_udp_handler},
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16710#pullrequestreview-738269385
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210825/a249c338/attachment.htm>


More information about the notifications mailing list