[riot-notifications] [RIOT-OS/RIOT] pkg/lwip: implement netif_get_name() (#16741)

Martine Lenders notifications at github.com
Thu Aug 26 13:17:14 CEST 2021


@miri64 commented on this pull request.



> @@ -84,6 +84,11 @@ ifneq (,$(filter lwip_contrib,$(USEMODULE)))
   USEMODULE += xtimer
 endif
 
+# should depend on netif instead

```diff
diff --git a/pkg/lwip/Makefile.dep b/pkg/lwip/Makefile.dep
index d674b83d10..d295e3504d 100644
--- a/pkg/lwip/Makefile.dep
+++ b/pkg/lwip/Makefile.dep
@@ -84,11 +84,14 @@ ifneq (,$(filter lwip_contrib,$(USEMODULE)))
   USEMODULE += xtimer
 endif
 
-# should depend on netif instead
 ifneq (,$(filter lwip_netif,$(USEMODULE)))
-  USEMODULE += fmt
+  USEMODULE += netif
 endif
 
 ifneq (,$(filter lwip_dhcp_auto,$(USEMODULE)))
   USEMODULE += lwip_dhcp
 endif
+
+ifneq (,$(filter netif,$(USEMODULE)))
+  USEMODULE += fmt
+endif
```

perfectly works for me when trying to build, so why not do it correctly directly?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16741#pullrequestreview-739345846
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210826/9e674d1b/attachment-0001.htm>


More information about the notifications mailing list