[riot-notifications] [RIOT-OS/RIOT] FIDO2 support in RIOT (#16489)

benpicco notifications at github.com
Fri Aug 27 13:26:42 CEST 2021


@benpicco commented on this pull request.



> +        }
+    }
+    else {
+        ret = mtd_write_page_raw(&_mtd_dev, buf, page, offset, len);
+
+        if (ret < 0) {
+            return CTAP1_ERR_OTHER;
+        }
+    }
+
+    return CTAP2_OK;
+}
+
+static bool _flash_is_erased(int page, int offset, size_t len)
+{
+    uint8_t *addr = ((uint8_t *)flashpage_addr(page) + offset);

Yes I just thought it would be nice if we could stick to the MTD API and not jump between abstraction layer.
If you want to fix this to `mtd_flashpage`, fine. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16489#discussion_r697365907
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210827/c2145952/attachment.htm>


More information about the notifications mailing list