[riot-notifications] [RIOT-OS/RIOT] Makefile.include: only warn if not curl, wget, unzip, 7z (#16784)

Francisco notifications at github.com
Mon Aug 30 08:53:52 CEST 2021


> > Another question to understand the patch: Why run through the bespoke `memoized` rather than just assigning immediately? I can't think of it as an optimization (especially because during assignment time the `which` binary and relevant paths are bound to be fresh in the OS cache), and don't see any other effect.
> 
> Just that since this is actually rarely used using memoized saves up on a `make $(shell)` call, it's one of those little impact optimizations, but if they were used everywhere could speed up a bit some things, kind of a good practice.

Its a bit explained here https://doc.riot-os.org/build-system-basics.html#variable-declaration-guidelines, but its basically that all `$(shell)` have a bit of overhead, when using `:=` this happens only once, so its more impactful when it's `= $(shell something)` since its called every time the variable is deference.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16784#issuecomment-908080762
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210829/668ed891/attachment.htm>


More information about the notifications mailing list