[riot-notifications] [RIOT-OS/RIOT] FIDO2 support in RIOT (#16489)

Nils Ollrogge notifications at github.com
Mon Aug 30 15:11:31 CEST 2021


@Ollrogge commented on this pull request.



> +        }
+    }
+    else {
+        ret = mtd_write_page_raw(&_mtd_dev, buf, page, offset, len);
+
+        if (ret < 0) {
+            return CTAP1_ERR_OTHER;
+        }
+    }
+
+    return CTAP2_OK;
+}
+
+static bool _flash_is_erased(int page, int offset, size_t len)
+{
+    uint8_t *addr = ((uint8_t *)flashpage_addr(page) + offset);

I just noticed that `mtd_flashpage` uses `FLAGPAGE_SIZE` for page_size instead of the `flagpage_size()`function. I am pretty sure this can break my code if `FLAGPAGE_SIZE` != `flagpage_size(i)` ...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16489#discussion_r698474713
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210830/e55482d2/attachment.htm>


More information about the notifications mailing list