[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6_simple_subnets: auto-configuration for nested subnets on a simple tree topology (#16536)

benpicco notifications at github.com
Tue Aug 31 17:01:36 CEST 2021


@benpicco commented on this pull request.



> +
+        /* first remove old prefix if the prefix changed */
+        _remove_old_prefix(downstream, &new_prefix, new_prefix_len, &ext_opts);
+
+        /* configure subnet on downstream interface */
+        gnrc_netif_ipv6_add_prefix(downstream, &new_prefix, new_prefix_len,
+                                   valid_ltime, pref_ltime);
+
+        /* start advertising subnet */
+        gnrc_ipv6_nib_change_rtr_adv_iface(downstream, true);
+
+        /* add route information option with new subnet */
+        tmp = gnrc_ndp_opt_ri_build(&new_prefix, new_prefix_len, valid_ltime,
+                                    NDP_OPT_RI_FLAGS_PRF_NONE, ext_opts);
+        if (tmp == NULL) {
+            DEBUG("auto_subnets: No space left in packet buffer. Not adding RIO\n");

I thought it would be still worthwhile to configure the downstream networks even if the packet buffer is currently exhausted to inform upstream.

We might also bail out here to make the breakage more visible. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16536#discussion_r699413960
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210831/636a07df/attachment.htm>


More information about the notifications mailing list