[riot-notifications] [RIOT-OS/RIOT] [WIP] cpu/cc26x2_cc13x2: add sub-1-ghz netdev driver (#13295)

mvystrcil notifications at github.com
Fri Jan 1 16:05:53 CET 2021


@mvystrcil requested changes on this pull request.



> +#define CC26X2_CC13X2_RF_PARAMS_H
+
+#include <stdint.h>
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+#define CC26X2_CC13X2_RF_PA_ENTRY(bias, gain, boost, coefficient) \
+    ((bias) << 0) | ((gain) << 6) | ((boost) << 8) | ((coefficient) << 9)
+
+/**
+ * @brief   RF PA table entry
+ */
+typedef struct {
+    uint8_t dbm;  /**< PA entry value in dBm */

Element `dbm` should be signed type, dbm is set to negative value in `cc26x2_cc13x2_rf_patable` array. Leading to value overflow when trying to set dbm power lower than 0.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13295#pullrequestreview-560591061
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210101/73edf318/attachment.htm>


More information about the notifications mailing list