[riot-notifications] [RIOT-OS/RIOT] cpu/qn908x: Implement blocking SPI support (#15689)

Marian Buschsieweke notifications at github.com
Sun Jan 3 08:57:13 CET 2021


@maribu commented on this pull request.



> +This driver uses the [OSHA SPI Signal Names](
+https://www.oshwa.org/a-resolution-to-redefine-spi-signal-names/) and while it
+only implements the Controller mode, the hardware is capable of operating in
+Peripheral mode as well so we use the COPI/CIPO names.

I agree with using CIPO/COPI instead of MISO/MOSI - despite the datasheet using other terms. But IMO we should keep naming consistently. So changing terminology should be done IMO throughout the code base. But IMO this is something to in its own PR.

So IMO you should either keep MISO/MOSI for now and change the terms together with all other instances, or wait for the terms in master to be changed before this can get upstream.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15689#discussion_r550971087
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210102/74b1f868/attachment.htm>


More information about the notifications mailing list