[riot-notifications] [RIOT-OS/RIOT] cpu/stm32f2f4f7: expose clock configuration in kconfig (#15632)

Alexandre Abadie notifications at github.com
Mon Jan 4 17:02:59 CET 2021


@aabadie commented on this pull request.



> +    default 96 if CPU_FAM_F4 && CLOCK_MAX_100MHZ && BOARD_HAS_HSE && (MODULE_PERIPH_USBDEV || USEMODULE_PERIPH_USBDEV)
+    default 48 if CPU_FAM_F4 && CLOCK_MAX_100MHZ && (MODULE_PERIPH_USBDEV || USEMODULE_PERIPH_USBDEV)

> we don't have any check in place to catch this invalid clock configuration when USB is used, right?

Yes we do, using preprocessor checks in the clock init code:

https://github.com/RIOT-OS/RIOT/blob/41eea7ab64382f219bba428176b6a617318ebf56/cpu/stm32/stmclk/stmclk_f2f4f7.c#L88-L93

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15632#discussion_r551406577
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210104/e04e3208/attachment.htm>


More information about the notifications mailing list