[riot-notifications] [RIOT-OS/RIOT] Github Actions: static-test: use base reference as base branch instead of master (#15662)

Alexandre Abadie notifications at github.com
Tue Jan 5 14:47:43 CET 2021


@aabadie commented on this pull request.



> @@ -61,7 +61,11 @@ if [ -n "${CI_BASE_COMMIT}" ]; then
     git tag "${CI_BASE_BRANCH}" "${CI_BASE_COMMIT}"
 fi
 
-CI_BASE_BRANCH=${CI_BASE_BRANCH:-master}
+if [ -z "${GITHUB_RUN_ID}" ]; then
+    # only default to master when not running in a GitHub action
+    # (so GitHub can check release branches too)

I don't understand this comment and why this if block is needed. Isn't CI_BASE_BRANCH env passed to docker container anyway (`-e CI_BASE_BRANCH=${{ github.base_ref }}`) ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15662#pullrequestreview-561799506
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210105/8e386914/attachment.htm>


More information about the notifications mailing list