[riot-notifications] [RIOT-OS/RIOT] tools/emulator: allow use with *term targets + introduce EMULATE=1 instead of emulate target (#15512)
notifications at github.com
Tue Jan 5 20:22:24 CET 2021
> Maybe we should use the occasion to transition to `make run` as "reset and connect me to the output? That would map more nicely to `EMULATE=1 make run`.
I agree that maybe this calls for a more descriptive name but I think probably out of scope for this PR.
btw, platformio uses `run` as a way to start a build and `monitor` to connect to the terminal, mbed uses `--sterm` and zephyr uses `run` for running emulator... I don't know about the `term` equivalent.
Anyways, I think we don't have or utilize that much support for emulators yet but I image that will be changing soon so it would be good to do the big changes now. I do like the fact that we don't need to change targets and it is just an env variable though I wonder if we may want to namespace it...
I would say overall I like it, maybe someone who knows more about build systems can say if it is better to use targets or env vars?
The only other things (before I start reviewing the code) would be to ensure that `EMULATE` is documented clearly somewhere, it shouldn't be one of those things that you have to be the owner of the feature to know. As well as maybe a target like `info-emulated-boards-supported` will be needed in the near future.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications