[riot-notifications] [RIOT-OS/RIOT] net/lorawan : Expose configurations to Kconfig (#15507)

Akshai M (Augustus Diode) notifications at github.com
Wed Jan 6 14:22:40 CET 2021


@akshaim commented on this pull request.



>   */
-#ifndef LORAMAC_DEFAULT_PUBLIC_NETWORK
-#define LORAMAC_DEFAULT_PUBLIC_NETWORK         (true)
-#endif
-/**
- * @brief   Default datarate
- */
-#ifndef LORAMAC_DEFAULT_DR
-#define LORAMAC_DEFAULT_DR                     (LORAMAC_DR_0)
+#ifdef DOXYGEN
+#define CONFIG_LORAMAC_DEFAULT_PUBLIC_NETWORK

Chances for a person to use a public network is more than that of a private network, hence the default behaviour makes sense as you suggested. But in that case, I will have to deprecate the current macro since it's `TRUE` by default. Is that fine?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15507#discussion_r552604010
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210106/a584dabc/attachment.htm>


More information about the notifications mailing list