[riot-notifications] [RIOT-OS/RIOT] cpu/atmega_common: Split into atmega_common and avr8_common (#15712)

Marian Buschsieweke notifications at github.com
Wed Jan 6 20:57:29 CET 2021


@maribu commented on this pull request.

The code changes look good to me. Some minor comments above.

> @@ -21,6 +21,7 @@
 #include "board.h"
 #include "cpu.h"
 #include "irq.h"
+#include "clock.h"

The other platforms don't provide a `clock.h` public header. For consistency, I would prefer AVR to follow suit. However, e.g. within `cpu.h` you can include internal headers to better structure code. It would be good if the internal headers would be "namespaced" if the use common names, e.g. `avr_clock.h` or `cpu_clock.h` shouldn't conflict with other headers.

> @@ -19,6 +19,7 @@
  */
 
 #include "board.h"
+#include "clock.h"

see above

> +ifneq (,$(filter cpu_avr8_common_cxx,$(USEMODULE)))
+  DIRS += cxx
+endif

This is either a leftover from the past or it slipped in by accident. In either case this can be dropped now. See https://github.com/RIOT-OS/RIOT/pull/15713

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15712#pullrequestreview-562987990
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210106/ffca8b58/attachment-0001.htm>


More information about the notifications mailing list