[riot-notifications] [RIOT-OS/RIOT] net/lorawan : Expose configurations to Kconfig (#15507)

José Alamos notifications at github.com
Thu Jan 7 11:09:55 CET 2021


@jia200x commented on this pull request.



>   */
-#ifndef LORAMAC_DEFAULT_MAX_FCNT_GAP
-#define LORAMAC_DEFAULT_MAX_FCNT_GAP           (16384U)
-#endif
-
-/**
- * @brief   Default adaptive datarate ACK limit (in s)
- */
-#ifndef LORAMAC_DEFAULT_ADR_ACK_LIMIT

These options are not used atm, but they could be easily added to the semtech pkg (and in the mid term to GNRC LoRaWAN). Maybe we could leave them there and simply not add them to Kconfig?

We can add a note to indicate they are not being used yet

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15507#pullrequestreview-563361907
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210107/5807c61b/attachment.htm>


More information about the notifications mailing list