[riot-notifications] [RIOT-OS/RIOT] net/lorawan : Expose configurations to Kconfig (#15507)

José Alamos notifications at github.com
Thu Jan 7 11:59:13 CET 2021


@jia200x commented on this pull request.



> +config LORAMAC_DEFAULT_RX2_DR_13
+    bool "DR13"
+
+config LORAMAC_DEFAULT_RX2_DR_14
+    bool "DR14"
+
+config LORAMAC_DEFAULT_RX2_DR_15
+    bool "DR15"
+
+endif # LORAMAC_REGION_US_915
+
+endchoice
+
+config LORAMAC_DEFAULT_RX2_FREQ
+    int "RX2 Frequency (in Hz)" if LORAMAC_ADVANCED_OPTIONS
+    depends on USEMODULE_RN2XX3 || USEMODULE_GNRC_LORAWAN

I suggest to not make this more complicate than it should be. To be precise, the RX2 range depend of the frequency plan. Within this range, the network server can decide the RX2 freq. So, it's not valid to assume this is dependent of the region.

 In practice this parameter is configured out of band with the required value of the network server anyway. The actual range or dependencies it might have won't add IMO more utilities than simply ensuring the app builds

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15507#discussion_r553257391
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210107/d3669fee/attachment.htm>


More information about the notifications mailing list