[riot-notifications] [RIOT-OS/RIOT] ci/flake8: fix some issues found by static-tests ran on master (#15720)
notifications at github.com
Thu Jan 7 18:44:30 CET 2021
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
This PR fixes the flake8 issues found by static tests when run on master ([see this static test job ran on master](https://github.com/RIOT-OS/RIOT/actions/runs/467209330)).
The changes are pretty obvious (and IMHO help for code readability). Maybe reviewers will have better suggestions for the variable names though.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
### Testing procedure
Just run `./dist/tools/flake8/check.sh` from RIOTBASE:
- This PR (empty output):
There are style issues in the following Python scripts:
dist/pythonlibs/testrunner/spawn.py:59:16: E741 ambiguous variable name 'l'
dist/tools/bmp/bmp.py:76:24: E741 ambiguous variable name 'l'
tests/cond_order/tests/01-run.py:10:1: F401 'os' imported but unused
tests/pbkdf2/tests/test_base.py:9:1: F401 'os' imported but unused
tests/pbkdf2/tests/test_base.py:30:24: E741 ambiguous variable name 'l'
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
Found by [this static tests job](https://github.com/RIOT-OS/RIOT/actions/runs/467209330)
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* dist/testrunner: fix flake8 issue E741
* dist/tools/bmp: fix flake8 issue E741
* tests/pbkdf2: fix flake8 issue E741: ambiguous variable name
-- File Changes --
M dist/pythonlibs/testrunner/spawn.py (4)
M dist/tools/bmp/bmp.py (10)
M tests/pbkdf2/tests/test_base.py (6)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications