[riot-notifications] [RIOT-OS/RIOT] dist/tools/commit-msg: annotate errors in Github Action (#15732)

MrKevinWeiss notifications at github.com
Sat Jan 9 13:31:24 CET 2021


@MrKevinWeiss commented on this pull request.

Running locally I get some number printed?
This PR
<details>

```
./dist/tools/commit-msg/check.sh 
256
Warning: Commit message is longer than 50 (but < 72) characters:
    "fixup! dist/tools/commit-msg: annotate errors in Github Action"
Warning: Commit message is longer than 50 (but < 72) characters:
    "fixup! dist/tools/commit-msg: annotate errors in Github Action"
Warning: Commit message is longer than 50 (but < 72) characters:
    "fixup! dist/tools/commit-msg: annotate errors in Github Action"
Warning: Commit message is longer than 50 (but < 72) characters:
    "fixup! dist/tools/commit-msg: annotate errors in Github Action"
Warning: Commit message is longer than 50 (but < 72) characters:
    "fixup! dist/tools/commit-msg: annotate errors in Github Action"
Warning: Commit message is longer than 50 (but < 72) characters:
    "REMOVE ME! This is just a test to check if a warning is triggered"
Error: Commit message is longer than 72 characters:
    "REMOVE ME! The answer to life, the universe, and everything is the number fourty-two"
Warning: Commit message is longer than 50 (but < 72) characters:
    "dist/tools/commit-msg: annotate errors in Github Action"
Warning: Commit message is longer than 50 (but < 72) characters:

```
</details>


vs master

<details>

```
./dist/tools/commit-msg/check.sh 
Error: Commit message is longer than 72 characters:
    "REMOVE ME test test test test test testasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdf"
Warning: Commit message is longer than 50 (but < 72) characters:
    "lostandfound: document removal of boards/slwstk6220a"
Warning: Commit message is longer than 50 (but < 72) characters:
    "sock/dtls: add example of a blocking handshake to the doc"
Warning: Commit message is longer than 50 (but < 72) characters:
    "pkg/tinydtls: implement sock_dtls_session_set_udp_ep"
Warning: Commit message is longer than 50 (but < 72) characters:

```
</details>


Colors are nice!

>  MSG_MAX_LENGTH=50
 MSG_STRETCH_LENGTH=72
 
+if tput colors &> /dev/null && [ $(tput colors) -ge 8 ]; then

It seems something in here makes me print 256 first...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15732#pullrequestreview-564780961
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210109/3185edd9/attachment.htm>


More information about the notifications mailing list