[riot-notifications] [RIOT-OS/RIOT] cpu/esp_common: Add missing includes and ISO-C++ compatibility (#15735)

jenswet notifications at github.com
Sun Jan 10 13:30:03 CET 2021


### Contribution description
This PR fixes two bugs:
1. Including `esp_now_params.h` was not possible from C++, because ISO-C++ forbids `char* var = "somevalue"` initialization without const. Even in C this is no good practice. The missing const statements were added for `esp_now_params_t`.
2. `esp_now_netdev.h` was not self-contained, because it uses definitions from headers that are not included. I've added these missing includes.

### Testing procedure
There shouldn't be much to test. You can try including the two headers in a C/C++ project before and after the PR and see the failing/fixed build.

CC @maribu 

You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/15735

-- Commit Summary --

  * cpu/esp_common: Add missing includes and ISO-C++ compatibility

-- File Changes --

    M cpu/esp_common/esp-now/esp_now_netdev.c (2)
    M cpu/esp_common/esp-now/esp_now_netdev.h (5)
    M cpu/esp_common/esp-now/esp_now_params.h (4)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/15735.patch
https://github.com/RIOT-OS/RIOT/pull/15735.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15735
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210110/6d15cec7/attachment.htm>


More information about the notifications mailing list