[riot-notifications] [RIOT-OS/RIOT] cpu/esp_common: Add missing includes and ISO-C++ compatibility (#15735)

benpicco notifications at github.com
Sun Jan 10 17:34:12 CET 2021


@benpicco commented on this pull request.

some whitespace nitpicks

> @@ -103,9 +103,9 @@
  */
 typedef struct
 {
-    uint8_t* key;         /**< key of type uint8_t [16] or NULL (no encryption) */
+    const uint8_t* key;         /**< key of type uint8_t [16] or NULL (no encryption) */

```suggestion
    const uint8_t* key;     /**< key of type uint8_t [16] or NULL (no encryption) */
```

>      uint32_t scan_period; /**< Period at which the node scans for other nodes */
-    char*    softap_pass; /**< Passphrase used for the SoftAP interface */
+    const char*    softap_pass; /**< Passphrase used for the SoftAP interface */

```suggestion
    const char* softap_pass; /**< Passphrase used for the SoftAP interface */
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15735#pullrequestreview-564879419
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210110/8a69305b/attachment-0001.htm>


More information about the notifications mailing list