[riot-notifications] [RIOT-OS/RIOT] usbus/dfu: add Device Firmware Upgrade support for USBUS (2nd attempt) (#15460)

Koen Zandberg notifications at github.com
Tue Jan 12 11:24:19 CET 2021


@bergzand commented on this pull request.

One minor nit remaining, feel free to squash immediately

> + * @defgroup    sys_riotboot_usb_dfu   Initialization of USB Device Firmware
+ *                                     Upgrade for riotboot
+ * @ingroup     sys
+ * @{
+ *
+ * @file
+ * @brief       USB DFU initialization for riotboot
+ *
+ * @author      Dylan Laduranty <dylan.laduranty at mesotic.com>
+ *
+ * @}
+ */
+
+#ifndef RIOTBOOT_USB_DFU_H
+#define RIOTBOOT_USB_DFU_H
+

Minor nit

```suggestion

#include "riotboot/hdr.h"

```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15460#pullrequestreview-566127538
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210112/0722cd4e/attachment-0001.htm>


More information about the notifications mailing list