[riot-notifications] [RIOT-OS/RIOT] syslog: add a simple syslog module (#15739)

Alexandre Abadie notifications at github.com
Tue Jan 12 12:21:57 CET 2021

@aabadie commented on this pull request.

> @@ -49,12 +52,14 @@ extern "C" {
  * time, so a lower log level might result in smaller code size.
 enum {
-    LOG_NONE,       /**< Lowest log level, will output nothing */
-    LOG_ERROR,      /**< Error log level, will print only critical,
-                         non-recoverable errors like hardware initialization
-                         failures */
+    LOG_NONE = -1,

I think that changing this enum is a strong API change regarding the log level. In master, the debug log level corresponds to the value 4, with this change, it would become 7 if I'm not mistaken.

I can see that at least the `tests/log_color` test application won't work anymore as expected because of this:


There might be other applications affected as well.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210112/a32136a6/attachment.htm>

More information about the notifications mailing list