[riot-notifications] [RIOT-OS/RIOT] syslog: add a simple syslog module (#15739)

Vincent Dupont notifications at github.com
Tue Jan 12 14:18:18 CET 2021

@vincent-d commented on this pull request.

> @@ -49,12 +52,14 @@ extern "C" {
  * time, so a lower log level might result in smaller code size.
 enum {
-    LOG_NONE,       /**< Lowest log level, will output nothing */
-    LOG_ERROR,      /**< Error log level, will print only critical,
-                         non-recoverable errors like hardware initialization
-                         failures */
+    LOG_NONE = -1,

Would this really be an issue? I mean we can update the test apps (a proper way could be using `CFLAGS += -DLOG_LEVEL=LOG_DEBUG`). IMO any user code should use the enum and not the value directly...

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210112/bc62ff17/attachment.htm>

More information about the notifications mailing list