[riot-notifications] [RIOT-OS/RIOT] sys/shell/commands/gnrc_icmpv6_echo: test for ICMPv6 reply corruption (#15622)

Martine Lenders notifications at github.com
Tue Jan 12 16:20:43 CET 2021


> What would we gain by making this optional? The Linux ping utility will always do the corruption check.

You wouldn't need to adapt the `riotctrl` stuff and not break the tests ;-).

> For `ShellInteraction`, would I just add `reply["corrupt"] = 1` in case the error line is printed?

The `ShellInteraction` itself probably doesn't need any adoption, since as far as I can see you don't change the command parameters. The parser, however, needs adoption. Since you provide offset information and stuff like that, I would prefer, if that information would be provided in the reply dictionary as well. E.g.

```py
reply["corrupt"] = {"bytes": bytes, "offset": offset}
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15622#issuecomment-758726811
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210112/661e41c6/attachment.htm>


More information about the notifications mailing list