[riot-notifications] [RIOT-OS/RIOT] dist/tools/pr_check: cleanup and annotate errors in Github Action (#15731)

Martine Lenders notifications at github.com
Tue Jan 12 16:33:55 CET 2021


@miri64 commented on this pull request.



> @@ -40,21 +43,20 @@ SQUASH_COMMITS="$(git log $(git merge-base HEAD "${RIOT_MASTER}")...HEAD --prett
                   keyword_filter)"
 
 if [ -n "${SQUASH_COMMITS}" ]; then
-    echo -e "${CERROR}Pull request needs squashing:${CRESET}" 1>&2
-    echo -e "${SQUASH_COMMITS}"
+    if github_annotate_is_on; then
+        echo "${SQUASH_COMMITS}" | while read commit; do
+            github_annotate_warning_no_file \

Because new contributors tend to immediately act on errors that they see in the CI, so I thought it would make more sense to keep it a warning. The check fail helps us to not merge accidentally, the message is a hint to the contributor.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15731#discussion_r555864218
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210112/ee86ca35/attachment.htm>


More information about the notifications mailing list