[riot-notifications] [RIOT-OS/RIOT] dist/tools/pr_check: cleanup and annotate errors in Github Action (#15731)

Alexandre Abadie notifications at github.com
Tue Jan 12 16:50:00 CET 2021


@aabadie commented on this pull request.



> @@ -40,21 +43,20 @@ SQUASH_COMMITS="$(git log $(git merge-base HEAD "${RIOT_MASTER}")...HEAD --prett
                   keyword_filter)"
 
 if [ -n "${SQUASH_COMMITS}" ]; then
-    echo -e "${CERROR}Pull request needs squashing:${CRESET}" 1>&2
-    echo -e "${SQUASH_COMMITS}"
+    if github_annotate_is_on; then
+        echo "${SQUASH_COMMITS}" | while read commit; do
+            github_annotate_warning_no_file \

I meant that when run locally, the message is displayed using the "error" style:

https://github.com/RIOT-OS/RIOT/blob/acd846653a23f953a86635f886e302244cf78604/dist/tools/pr_check/check.sh#L50

That's why I think that, for consistency, the error style should also be used in the annotation.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15731#discussion_r555876309
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210112/d37e43a1/attachment.htm>


More information about the notifications mailing list