[riot-notifications] [RIOT-OS/RIOT] dist/tools/vera++: annotate errors in Github Action (#15753)

Martine Lenders notifications at github.com
Tue Jan 12 19:17:31 CET 2021


@miri64 commented on this pull request.



>  echo "$FILES" | $VERA_CMD --profile riot \
-    --parameters $CURDIR/profiles/riot_params.txt -w
+    --parameters $CURDIR/profiles/riot_params.txt -w 2>&1 | ${LOG}
+# Uncomment when the script should error
+# RESULT=${PIPESTATUS[0]}
+
+if github_annotate_is_on; then
+    _annotate() {
+        FILENAME=$(echo "${line}" | cut -d: -f1)
+        LINENUM=$(echo "${line}" | cut -d: -f2)
+        DETAILS=$(echo "${line}" | cut -d: -f3- |
+                  sed -e 's/^[ \t]*//' -e 's/[ \t]*$//')
+
+        # parse if warning (errors don't have a label)

> Note that errors do have an "error" label. Since we pass `-w` to the vera++ invocation, we see all errors as warnings

But see my [run with the `-w` removed](https://github.com/RIOT-OS/RIOT/pull/15753/checks?check_run_id=1689822766#step:5:29). Here the error does not have an error label. Anyway, I will test with `-e` and adopt if necessary!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15753#discussion_r555978759
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210112/745a44b3/attachment.htm>


More information about the notifications mailing list