[riot-notifications] [RIOT-OS/RIOT] sys/net/gnrc: fix in-band signaling of no RSSI/LQI (#15754)

Marian Buschsieweke notifications at github.com
Tue Jan 12 20:07:35 CET 2021


@maribu commented on this pull request.



> @@ -46,6 +46,19 @@ extern "C" {
  */
 #define GNRC_NETIF_HDR_L2ADDR_PRINT_LEN (GNRC_NETIF_HDR_L2ADDR_MAX_LEN * 3)
 
+/**
+ * @brief   Special value to indicate that no RSSI value is present
+ *
+ * See @ref gnrc_netif_hdr_t::rssi
+ */
+#define GNRC_NETIF_HDR_NO_RSSI          (INT16_MIN)
+/**
+ * @brief   Special value to indicate that no LQI value is present
+ *
+ * See @ref gnrc_netif_hdr_t::lqi
+ */
+#define GNRC_NETIF_HDR_NO_LQI           (INT8_MIN)

I though I read `int8_t`. There doesn't seem to be a standard for LQI, other transceivers give valies from 0 to 100. There -128 (if it would have been signed) would be clearly out of range.

I guess than `UINT8_MIN` is the best value and drivers would habe to round up zero one :-(

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15754#discussion_r556008383
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210112/31ed7a88/attachment.htm>


More information about the notifications mailing list