[riot-notifications] [RIOT-OS/RIOT] sys/net/gnrc/sock: cleanup & fix aux handling (#15757)

Marian Buschsieweke notifications at github.com
Tue Jan 12 21:19:43 CET 2021


### Contribution description

The logic used to check whether the RX timestamp was send in the GNRC
implementation of `sock_ip_recv_buf_aux()` is incorrect: It still uses in-band
signalling via a timestamp of zero, but a dedicated flag was added to allow for
timestamps of zero.

Additionally the GNRC implementations of both `sock_ip_recv_buf_aux()` and
`sock_udp_recv_buf_aux()` have been simplified: There is little value to check
if a bit is set an than clearing it - one can just as well simply clear it
unconditionally.

### Testing procedure

The tests `tests/gnrc_sock_ip` and `tests/gnrc_sock_udp` should still pass.

### Issues/PRs references

None
You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/15757

-- Commit Summary --

  * sys/net/gnrc/sock: cleanup & fix aux handling

-- File Changes --

    M sys/net/gnrc/sock/ip/gnrc_sock_ip.c (13)
    M sys/net/gnrc/sock/udp/gnrc_sock_udp.c (13)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/15757.patch
https://github.com/RIOT-OS/RIOT/pull/15757.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15757
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210112/ef690c2c/attachment.htm>


More information about the notifications mailing list