[riot-notifications] [RIOT-OS/RIOT] dist/tools/pr_check: cleanup and annotate errors in Github Action (#15731)

MrKevinWeiss notifications at github.com
Wed Jan 13 12:28:17 CET 2021


@MrKevinWeiss requested changes on this pull request.

Almost

> @@ -40,21 +43,24 @@ SQUASH_COMMITS="$(git log $(git merge-base HEAD "${RIOT_MASTER}")...HEAD --prett
                   keyword_filter)"
 
 if [ -n "${SQUASH_COMMITS}" ]; then
-    echo -e "${CERROR}Pull request needs squashing:${CRESET}" 1>&2
-    echo -e "${SQUASH_COMMITS}"
+    if github_annotate_is_on; then
+        echo "${SQUASH_COMMITS}" | while read commit; do
+            ANNOTATION="Commit needs to be squashed: \"${commit}\""
+            ANNOTATION="${ANNOTATION}\n\nPLEASE ONLY SQUASH WHEN ASKED BY A"

```suggestion
            ANNOTATION="${ANNOTATION}\n\nPLEASE ONLY SQUASH WHEN ASKED BY A "
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15731#pullrequestreview-567130690
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210113/9b748021/attachment-0001.htm>


More information about the notifications mailing list