[riot-notifications] [RIOT-OS/RIOT] dist/tools/uncrustify: annotate errors in Github Action (#15748)

José Alamos notifications at github.com
Wed Jan 13 14:04:28 CET 2021


```
 Error: Uncrustify proposes the following patch:

--- a/core/mutex.c
+++ a/core/mutex.c
@@ -111,7 +113,7 @@ int mutex_lock_cancelable(mutex_cancel_t *mc)
DEBUG("PID[%" PRIkernel_pid "] mutex_lock_cancelable() "
"cancelled.n", thread_getpid());
}
-        return (mc->cancelled)?-ECANCELED: 0;
+        return (mc->cancelled) ? -ECANCELED : 0;
}
}

Error: Uncrustify proposes the following patch:

--- a/core/mutex.c
+++ a/core/mutex.c
@@ -185,6 +187,7 @@ void mutex_unlock_and_sleep(mutex_t *mutex)
void mutex_cancel(mutex_cancel_t *mc)
{
unsigned irq_state = irq_disable();
+
mc->cancelled = 1;

mutex_t *mutex = mc->mutex;
Error: Uncrustify proposes the following patch:

--- a/core/mutex.c
+++ a/core/mutex.c
@@ -197,8 +200,8 @@ void mutex_cancel(mutex_cancel_t *mc)
}

if ((mutex->queue.next != MUTEX_LOCKED)
-            && (mutex->queue.next != NULL)
-            && list_remove(&mutex->queue, (list_node_t *)&thread->rq_entry)) {
+        && (mutex->queue.next != NULL)
+        && list_remove(&mutex->queue, (list_node_t *)&thread->rq_entry)) {
/* Thread was queued and removed from list, wake it up */
if (mutex->queue.next == NULL) {
mutex->queue.next = MUTEX_LOCKED;
Error: Uncrustify proposes the following patch:
```

Nice one :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15748#issuecomment-759435215
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210113/1788360a/attachment-0001.htm>


More information about the notifications mailing list