[riot-notifications] [RIOT-OS/RIOT] sys/inet/ieee802154/radio: fix wrong rssi conversions treewide (#15616)

Francisco notifications at github.com
Wed Jan 13 17:18:12 CET 2021


@fjmolinas commented on this pull request.



> +            /* We calculate RSSI from LQI, since it's already 8-bit
+               saturated */

> Note that `lqi` is set to `GNRC_NETIF_HDR_NO_LQI` in `gnrc_netif_hdr_init()` (or via `gnrc_netif_hdr_build()`, which calls in turn `gnrc_netif_hdr_init()`. So if you leave `lqi` untouched, it will have that value already.

I would rather not use `GNRC_NETIF_HDR_NO_LQI` this is not related to `gnrc`, so this value is only correctly set if gnrc is used.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15616#discussion_r556651251
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210113/11491bde/attachment-0001.htm>


More information about the notifications mailing list