[riot-notifications] [RIOT-OS/RIOT] README: Add merge-chance badge (#15737)
notifications at github.com
Wed Jan 13 19:14:23 CET 2021
> > I am happy that you found merge-chance useful! Let me know if you have any feedback / feature requests.
> Hi @PiotrZakrzewski, happy you are happy :-). As stated above, from my sample taken by hand with GraphQL, one of our maintainers (probably more) is for some inexplicable reason listed as a `CONTRIBUTOR`, not a member. It would be great if you could, if possible, shed some light on why that is the case.
`authorAffiliation` which I use for determining if someone is an "insider" is saved at the time of making a PR, GitHub even has some special affiliations such as "first time contributor", which would be broken if they were recomputed later on. If the author is (at the time of making the PR) a member of GitHub org owning the repo they will get `MEMBER` affiliation for this PR. If they were invited to contribute to the repository (by giving them some rights, GitHub is not specific on that ...) but are not member of the GitHub org then they will be classified as `COLLABORATOR`, a `CONTRIBUTOR` in theory should be anyone else who shows up in the contributor tab (i.e. has merged contributions already). So if I understand everything correctly and the system works as it is described in the docs those maintainers were not (yet?) members of RIOT-OS GitHub organisation, do you this is possible?
If you add all maintainers to RIOT-OS organization then all new PRs should be created with authorAffiliation `MEMBER` and merge-chance.info will ignore them.
It will take some time for stats to converge as I take up to 300 prs in consideration.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications