[riot-notifications] [RIOT-OS/RIOT] drivers/{o, p, q, r}*: add modules to Kconfig (#15708)

Francisco notifications at github.com
Thu Jan 14 09:24:49 CET 2021


@fjmolinas commented on this pull request.

Looks good, one comment.

> @@ -0,0 +1,15 @@
+# Copyright (c) 2021 HAW Hamburg
+#
+# This file is subject to the terms and conditions of the GNU Lesser
+# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+#
+
+config MODULE_PCA9685
+    bool "PCA9685 I2C PWM controller"
+    depends on HAS_PERIPH_GPIO
+    depends on HAS_PERIPH_I2C
+    depends on TEST_KCONFIG

Seem to be missing:

```
# efm32 CPU doesn't support PWM_RIGHT
FEATURES_BLACKLIST += arch_efm32
```

So I guess `depends on !CPU_ARCH_EFM32`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15708#pullrequestreview-568002000
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210114/5a9de0ed/attachment.htm>


More information about the notifications mailing list