[riot-notifications] [RIOT-OS/RIOT] nrf802154/hal: fix unwanted emissions at the end of ACK frame (#15766)
notifications at github.com
Thu Jan 14 11:25:11 CET 2021
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
This commit turns off the transceiver immediately after sending an ACK frame in order to avoid unwanted emissions (see ERRATA ID 204).
When the radio stays in TX_ON without an explicit transition, the radio keeps sending a spurious signal for some milliseconds.
Check the following picture to see how this looks like (using the SDR, Y axis is RF power, X axis is time, first frame is the CC2538 and the second one is the ACK of the nrf802154)
And this is how it looks with this PR:
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
### Testing procedure
Hard to test without an SDR, but at least make sure that some ping stress tests still work ok.
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
None so far
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* cc2538_rf/radio_hal: fix transmit function
* nrf802154/hal: fix unwanted emissions at the end of ACK frame
-- File Changes --
M cpu/cc2538/radio/cc2538_rf_radio_ops.c (7)
M cpu/nrf52/radio/nrf802154/nrf802154_radio.c (5)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications