[riot-notifications] [RIOT-OS/RIOT] syslog: add a simple syslog module (#15739)

Alexandre Abadie notifications at github.com
Thu Jan 14 12:30:46 CET 2021


@aabadie commented on this pull request.



> @@ -49,12 +52,14 @@ extern "C" {
  * time, so a lower log level might result in smaller code size.
  */
 enum {
-    LOG_NONE,       /**< Lowest log level, will output nothing */
-    LOG_ERROR,      /**< Error log level, will print only critical,
-                         non-recoverable errors like hardware initialization
-                         failures */
+    LOG_NONE = -1,

When directly used with CFLAGS, the enum can indeed be used directly and it's clearer.
There's also the corresponding Make variable `LOG_LEVEL` and its documentation that should be adapted:

https://github.com/RIOT-OS/RIOT/blob/bd5b195433d42ca5f29d348f7b967e609e33452a/makefiles/vars.inc.mk#L119

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15739#discussion_r557328736
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210114/1c8a6f58/attachment.htm>


More information about the notifications mailing list