[riot-notifications] [RIOT-OS/RIOT] radio/nrf802154: fix set_cca_threshold range (#15636)

Francisco notifications at github.com
Thu Jan 14 14:21:06 CET 2021


@fjmolinas approved this pull request.

ACK, tested, the overflow is evident when looking at the conversion formula

- master:

```
config_cca ed -93
2021-01-14 14:17:57,638 # config_cca ed -93
2021-01-14 14:17:57,639 # CCA mode set.
2021-01-14 14:17:57,641 # Set threshold to -93
> config_cca ed -92
2021-01-14 14:17:59,694 #  config_cca ed -92
2021-01-14 14:17:59,695 # CCA mode set.
2021-01-14 14:17:59,697 # Set threshold to -92
```

- pr:

```
> config_cca ed -93
2021-01-14 14:17:19,338 #  config_cca ed -93
2021-01-14 14:17:19,339 # CCA mode set.
2021-01-14 14:17:19,342 # Error setting the threshold
> config_cca ed -92
2021-01-14 14:17:22,643 #  config_cca ed -92
2021-01-14 14:17:22,644 # CCA mode set.
2021-01-14 14:17:22,646 # Set threshold to -92
```



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15636#pullrequestreview-568224723
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210114/c5ff15fb/attachment-0001.htm>


More information about the notifications mailing list