[riot-notifications] [RIOT-OS/RIOT] drivers: add bq2429x power management IC driver (#15523)

Leandro Lanzieri notifications at github.com
Fri Jan 15 09:39:05 CET 2021


@leandrolanzieri commented on this pull request.

Some comments on the Kconfig :-) 

> @@ -0,0 +1,33 @@
+# Copyright (C) 2020 Locha Inc
+#
+# This file is subject to the terms and conditions of the GNU Lesser
+# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+#
+
+config MODULE_BQ2429X

```suggestion
menuconfig MODULE_BQ2429X
```

> @@ -0,0 +1,33 @@
+# Copyright (C) 2020 Locha Inc
+#
+# This file is subject to the terms and conditions of the GNU Lesser
+# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+#
+
+config MODULE_BQ2429X
+    bool "BQ2429x"

```suggestion
    bool "BQ2429x single-Cell USB charger"
```

> +#
+
+config MODULE_BQ2429X
+    bool "BQ2429x"
+    depends on HAS_PERIPH_I2C
+    depends on HAS_PERIPH_GPIO
+    depends on TEST_KCONFIG
+    select MODULE_PERIPH_I2C
+    select MODULE_PERIPH_GPIO
+    default y if HAVE_BQ2429X
+
+config MODULE_BQ2429X_INT
+    bool "BQ2429x with interrupt functionality"
+    depends on HAS_PERIPH_GPIO_IRQ
+    select MODULE_PERIPH_GPIO_IRQ
+    select MODULE_BQ2429X

I think this should be a dependency instead, as we try to model things bottom-up
```suggestion
    depends on MODULE_BQ2429X
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15523#pullrequestreview-569053157
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210115/dcc221e5/attachment.htm>


More information about the notifications mailing list