[riot-notifications] [RIOT-OS/RIOT] drivers/bme680: replace pkg with module (#15738)
notifications at github.com
Fri Jan 15 15:36:33 CET 2021
In general, using vendor or other drivers as a package and integrating them into RIOT through a simple wrapper interface has the advantage that thousands of existing drivers can be integrated into RIOT very easily. Such an approach was used in PR #10363 the first time. Unfortunately, this PR is waiting for review for over two years :worried: The general approach and the standardized wrapper interface were discussed in issue #10506. The BME680 driver as provided in PR #10502 and PR #12717 followed this approach. The ATWINC15x0 driver provided in PR #13754 also uses this approach.
Regarding the BME680 driver, I'm not strictly against replacing the vendor driver with a native one if you strongly recommend it, f
for example, because the BSEC integration will never be possible anyway due to licensing problems and the BOSCH code is of poor quality, which I fully agree with. Of course, the native driver should at least have no disadvantages.
One of my concerns is that the verdor driver at least theoretically gives the users the ability to integrate the BSEC if they agree to the license terms. This will not be possible with the native driver. However, without the BSEC and the ability to convert gas resistance values to IAQ indices, the BME680 is nothing more than a simple temperature, humidity and pressure sensor. Its most important function remains unused.
Regarding the code. It would be good if it could be improved a bit before a review. The code has a lot of [code style](https://github.com/RIOT-OS/RIOT/blob/master/CONTRIBUTING.md) violations that should be fixed before.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications