[riot-notifications] [RIOT-OS/RIOT] makefiles/docker.inc.mk: add and version_is_greater_or_equal for jobs check (#15785)

Francisco notifications at github.com
Mon Jan 18 14:46:56 CET 2021


### Contribution description

Follow up to https://github.com/RIOT-OS/RIOT/pull/15196, add and use a `is_version_equal_or_greater` for improved readability.

### Testing procedure

**Force a version match**

- Equal version: `BUILD_IN_DOCKER=1 make -C examples/hello-world/ all -j4 MAKE_VERSION=4.2`

```
make: Entering directory '/home/francisco/workspace/RIOT/examples/hello-world'
Launching build container using image "riot/riotbuild:latest".
docker run --rm --tty --user $(id -u) -v '/usr/share/zoneinfo/Europe/Paris:/etc/localtime:ro' -v '/home/francisco/workspace/RIOT:/data/riotbuild/riotbase:delegated' -e 'RIOTBASE=/data/riotbuild/riotbase' -e 'CCACHE_BASEDIR=/data/riotbuild/riotbase' -e 'BUILD_DIR=/data/riotbuild/riotbase/build' -e 'RIOTPROJECT=/data/riotbuild/riotbase' -e 'RIOTCPU=/data/riotbuild/riotbase/cpu' -e 'RIOTBOARD=/data/riotbuild/riotbase/boards' -e 'RIOTMAKE=/data/riotbuild/riotbase/makefiles'        -w '/data/riotbuild/riotbase/examples/hello-world/' 'riot/riotbuild:latest' make     -j4 all
```

- Lower version: `BUILD_IN_DOCKER=1 make -C examples/hello-world/ all -j4 MAKE_VERSION=4.1.1`
```
make: Entering directory '/home/francisco/workspace/RIOT/examples/hello-world'
Launching build container using image "riot/riotbuild:latest".
docker run --rm --tty --user $(id -u) -v '/usr/share/zoneinfo/Europe/Paris:/etc/localtime:ro' -v '/home/francisco/workspace/RIOT:/data/riotbuild/riotbase:delegated' -e 'RIOTBASE=/data/riotbuild/riotbase' -e 'CCACHE_BASEDIR=/data/riotbuild/riotbase' -e 'BUILD_DIR=/data/riotbuild/riotbase/build' -e 'RIOTPROJECT=/data/riotbuild/riotbase' -e 'RIOTCPU=/data/riotbuild/riotbase/cpu' -e 'RIOTBOARD=/data/riotbuild/riotbase/boards' -e 'RIOTMAKE=/data/riotbuild/riotbase/makefiles'        -w '/data/riotbuild/riotbase/examples/hello-world/' 'riot/riotbuild:latest' make      all
```

- Higher vesrion: `BUILD_IN_DOCKER=1 make -C examples/hello-world/ all -j4 MAKE_VERSION=4.3`
```
make: Entering directory '/home/francisco/workspace/RIOT/examples/hello-world'
Launching build container using image "riot/riotbuild:latest".
docker run --rm --tty --user $(id -u) -v '/usr/share/zoneinfo/Europe/Paris:/etc/localtime:ro' -v '/home/francisco/workspace/RIOT:/data/riotbuild/riotbase:delegated' -e 'RIOTBASE=/data/riotbuild/riotbase' -e 'CCACHE_BASEDIR=/data/riotbuild/riotbase' -e 'BUILD_DIR=/data/riotbuild/riotbase/build' -e 'RIOTPROJECT=/data/riotbuild/riotbase' -e 'RIOTCPU=/data/riotbuild/riotbase/cpu' -e 'RIOTBOARD=/data/riotbuild/riotbase/boards' -e 'RIOTMAKE=/data/riotbuild/riotbase/makefiles'        -w '/data/riotbuild/riotbase/examples/hello-world/' 'riot/riotbuild:latest' make     -j4 all
```

### Issues/PRs references

Follow up on https://github.com/RIOT-OS/RIOT/pull/15196
You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/15785

-- Commit Summary --

  * makefiles/utils/strings.mk: add version_greater_or_equal
  * makefiles/docker.inc.mk: use version_is_greater_or_equal for jobs check

-- File Changes --

    M makefiles/docker.inc.mk (4)
    M makefiles/utils/strings.mk (13)
    M makefiles/utils/test-strings.mk (10)
    M tests/build_system_utils/Makefile (4)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/15785.patch
https://github.com/RIOT-OS/RIOT/pull/15785.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15785
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210118/3d4bde61/attachment.htm>


More information about the notifications mailing list