[riot-notifications] [RIOT-OS/RIOT] tests/posix_sleep: fix for invalid RTT configurations (#15794)

Alexandre Abadie notifications at github.com
Tue Jan 19 12:44:19 CET 2021


@aabadie commented on this pull request.

Initial comments :)

> @@ -2,8 +2,12 @@ include ../Makefile.tests_common
 
 USEMODULE += posix_sleep
 
-# Pull-in periph-rtt on board that provides this feature to switch to the RTT
-# backend of ztimer
-FEATURES_OPTIONAL += periph_rtt
+# This CPU families have a non configurable RTT of 1Hz, not enough for

```suggestion
# These CPU families have a non configurable RTT of 1Hz, not enough for
```

> @@ -2,8 +2,12 @@ include ../Makefile.tests_common
 
 USEMODULE += posix_sleep
 
-# Pull-in periph-rtt on board that provides this feature to switch to the RTT
-# backend of ztimer
-FEATURES_OPTIONAL += periph_rtt
+# This CPU families have a non configurable RTT of 1Hz, not enough for
+# ztimer_msec to run on periph_rtt
+ifeq (,$(filter efm32 kinetis,$(CPU)))
+  # Pull-in periph-rtt on board that provides this feature to switch to the RTT

```suggestion
  # Pull-in periph-rtt on boards that provide this feature to switch to the RTT
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15794#pullrequestreview-571162253
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210119/3f148bab/attachment.htm>


More information about the notifications mailing list