[riot-notifications] [RIOT-OS/RIOT] cpu/nrf5x: enhance external HF clock source handling to allow for substantial energy savings (#15804)

benpicco notifications at github.com
Wed Jan 20 14:22:59 CET 2021


@benpicco commented on this pull request.



> @@ -247,6 +248,11 @@ static int _init(netdev_t *dev)
     txbuf[0] = 0;
     _state = 0;
 
+    /* the radio need the external HF clock source to be enabled */
+    /* @todo    add proper handling to release the clock whenever the radio is
+     *          idle */
+    clock_hfxo_request();

Since those always occur together, how about adding a 

```C
static inline void nrf5x_radio_on(void)
{
    clock_hfxo_request();
    NRF_RADIO->POWER = 1;
}

static inline void nrf5x_radio_off(void)
{
    NRF_RADIO->POWER = 0;
    clock_hfxo_release();
}
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15804#discussion_r560955074
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210120/a850f2a8/attachment.htm>


More information about the notifications mailing list